Page MenuHomePhabricator
Differential D1964

Replace save|restoreWindowGeometry with Qt functions
ClosedPublic
Actions

Authored by jasonbcox on Oct 23 2018, 23:36.

Details

Reviewers
deadalnix
schancel
Group Reviewers
Restricted Project
Commits
rSTAGING4c4ca6c7c27c: Replace save|restoreWindowGeometry with Qt functions
rABC4c4ca6c7c27c: Replace save|restoreWindowGeometry with Qt functions
Summary

Backport of Core PR11335
Completes T442 and T318

Co-authored-by: Jason B. Cox <contact@jasonbcox.com>

Test Plan

ninja

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr11335
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3684
Build 5443: Bitcoin ABC Buildbot (legacy)
Build 5442: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Oct 23 2018, 23:36
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 23 2018, 23:36
teamcity added a subscriber: teamcity.Oct 23 2018, 23:38

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Oct 23 2018, 23:46

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3670: Diff 5519.Oct 23 2018, 23:47
jasonbcox edited the summary of this revision. (Show Details)Oct 23 2018, 23:54
deadalnix requested changes to this revision.Oct 24 2018, 23:23

Same as D1963, it looks good but description needs to be updated.

This revision now requires changes to proceed.Oct 24 2018, 23:23
deadalnix mentioned this in D1965: [Qt] Don't add arguments of sensitive command to console window.Oct 24 2018, 23:25
deadalnix mentioned this in D1966: Make tabs toolbar no longer have a context menu.
jasonbcox requested review of this revision.Oct 25 2018, 00:58
jasonbcox edited the summary of this revision. (Show Details)
schancel accepted this revision.Oct 25 2018, 20:32
deadalnix accepted this revision.Oct 25 2018, 22:00
This revision is now accepted and ready to land.Oct 25 2018, 22:00
jasonbcox updated this revision to Diff 5536.Oct 25 2018, 22:27

Rebase

teamcity added a comment.Oct 25 2018, 22:28

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Oct 25 2018, 22:36

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3684: Diff 5536.Oct 25 2018, 22:36
Closed by commit rABC4c4ca6c7c27c: Replace save|restoreWindowGeometry with Qt functions (authored by MeshCollider <dobsonsa68@gmail.com>, committed by jasonbcox). · Explain WhyOct 25 2018, 23:06
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
qt/
10 lines
6 lines
22 lines
13 lines

Diff 5536

View Options

src/qt/bitcoingui.cpp

Loading...
View Options

src/qt/guiutil.h

Loading...
View Options

src/qt/guiutil.cpp

Loading...
View Options

src/qt/rpcconsole.cpp

Loading...