Discovered while working on backports
Details
Details
- Reviewers
deadalnix schancel - Group Reviewers
Restricted Project - Commits
- rSTAGING4a9b35aa3080: Fix bug in UnwindBlock that could unpark or unfail a parked or failed chain
rABC4a9b35aa3080: Fix bug in UnwindBlock that could unpark or unfail a parked or failed chain
test_runner.py abc-parkedchain
Fails without the fix and passes with it.
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- parked
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 3720 Build 5515: Bitcoin ABC Buildbot (legacy) Build 5514: arc lint + arc unit
Event Timeline
| src/validation.cpp | ||
|---|---|---|
| 2731 ↗ | (On Diff #5575) | You don't need to pass true. It would also make sense to use a ternary, inline, without creating a whole sub function. |
| 2746 ↗ | (On Diff #5575) | This is not correct, even thought it end up having the same result. It should be withFailedParent/.withParkedParent . |
| test/functional/abc-parkedchain.py | ||
| 19 ↗ | (On Diff #5575) | Please do not number the tests, because it ends up making reordering/removing a test in the middle more tedious than needed. |
| 48 ↗ | (On Diff #5575) | This needs to go to the final step of reconsidering the invalid chain, as well as other possible interleavings of:
There should be 4. |
| test/functional/abc-parkedchain.py | ||
|---|---|---|
| 47 | check the tip between the two | |
| 49 | You'd benefit also checking what happen after reconsiderblock here. | |
| 64 | And check unpark. | |
| 84 | This is redunddant witht he test cases above is requested changes are applied. However, these cases are missing:
and
| |