Page MenuHomePhabricator
Differential D1990

scripted-diff: Use UniValue.pushKV instead of push_back(Pair())
ClosedPublic
Actions

Authored by schancel on Oct 31 2018, 18:59.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGINGc8c4ff20a84f: scripted-diff: Use UniValue.pushKV instead of push_back(Pair())
rABCc8c4ff20a84f: scripted-diff: Use UniValue.pushKV instead of push_back(Pair())
Summary

-BEGIN VERIFY SCRIPT-
git grep -l "push_back(Pair" | xargs sed -i "s/push_back(Pair(\(.*\)));/pushKV(\1);/g"
-END VERIFY SCRIPT-

Depends on D1989

Test Plan
make check && ./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

schancel created this revision.Oct 31 2018, 18:59
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 31 2018, 18:59
teamcity added a subscriber: teamcity.Oct 31 2018, 19:02

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Oct 31 2018, 19:10

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3733: Diff 5599.Oct 31 2018, 19:10
jasonbcox accepted this revision.Oct 31 2018, 20:20
This revision is now accepted and ready to land.Oct 31 2018, 20:20
Closed by commit rABCc8c4ff20a84f: scripted-diff: Use UniValue.pushKV instead of push_back(Pair()) (authored by Karel Bilek <kb@karelbilek.com>, committed by schancel). · Explain WhyOct 31 2018, 20:56
This revision was automatically updated to reflect the committed changes.
schancel mentioned this in D2064: Finish conversion of rpc to use pushKV.Nov 13 2018, 19:19
Fabien mentioned this in rABC3d981bc03584: Finish conversion of rpc to use pushKV.Nov 22 2018, 15:22
Fabien mentioned this in rSTAGING3d981bc03584: Finish conversion of rpc to use pushKV.Nov 30 2018, 21:33
markblundeberg added a subscriber: markblundeberg.May 24 2019, 18:20

(is backport of PR12193)

Revision Contents
Changeset List

PathSize
src/
8 lines
rpc/
2 lines
162 lines
50 lines
68 lines
114 lines
18 lines
64 lines
wallet/
2 lines
138 lines

Diff 5602

View Options

src/rest.cpp

Loading...
View Options

src/rpc/abc.cpp

Loading...
View Options

src/rpc/blockchain.cpp

Loading...
View Options

src/rpc/mining.cpp

Loading...
View Options

src/rpc/misc.cpp

Loading...
View Options

src/rpc/net.cpp

Loading...
View Options

src/rpc/protocol.cpp

Loading...
View Options

src/rpc/rawtransaction.cpp

Loading...
View Options

src/wallet/rpcdump.cpp

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...