Differential D1998

Use for-loop instead of list comprehension
ClosedPublic
Actions

Authored by jasonbcox on Nov 2 2018, 21:26.

Details

Reviewers

deadalnix
schancel
Fabien

Group Reviewers

Restricted Project

Commits

rSTAGINGbc19d42d5a07: Use for-loop instead of list comprehension
rABCbc19d42d5a07: Use for-loop instead of list comprehension

Summary

To make it clear that we are intentionally using it for its
side-effects.

Backport 1-of-6 for Core PR10781
T473

Test Plan

test_runner.py p2p-compactblocks

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr10781-1

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3751
Build 5577: Bitcoin ABC Buildbot (legacy)
Build 5576: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Nov 2 2018, 21:26

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 2 2018, 21:26

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3751: Diff 5626.Nov 2 2018, 21:36

Fabien accepted this revision as: Fabien.Nov 2 2018, 21:49

This revision is now accepted and ready to land.Nov 2 2018, 21:49

Closed by commit rABCbc19d42d5a07: Use for-loop instead of list comprehension (authored by practicalswift <practicalswift@users.noreply.github.com>, committed by jasonbcox). · Explain WhyNov 2 2018, 21:58

This revision was automatically updated to reflect the committed changes.

jasonbcox edited the summary of this revision. (Show Details)Nov 2 2018, 22:23

Revision Contents
Changeset List

Path

Size

test/

functional/

p2p-compactblocks.py

3 lines

Diff 5626

View Options

test/functional/p2p-compactblocks.py

Use for-loop instead of list comprehensionClosedPublicActions