Page MenuHomePhabricator

[rpc] Undeprecate estimatefee
ClosedPublic

Authored by schancel on Nov 6 2018, 17:42.

Details

Summary

Revert "[rpc] Deprecate estimatefee RPC" (D1920)

This reverts PARTIALLY reverts commit 49ff27fedd365dcf5f7639fd2bda5dfc3cc58f51

The instrumentation for enabling deprecated RPCs is left in place for future use.
However, estimatefee should not be deprecated in a point release. It's also possible
that it should not be deprecated at all since we removed estimatesmartefee which
core deprecated this in favor of.

Depends on D2013

Test Plan
make check && ./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

schancel edited the summary of this revision. (Show Details)
deadalnix requested changes to this revision.Nov 6 2018, 17:54
deadalnix added a subscriber: deadalnix.

1/ Why this should not be deprecated ?
2/ This remove any testing of the deprecated capabilities.

This revision now requires changes to proceed.Nov 6 2018, 17:54

Because people use it? It was deprecated in favor of estimatesmartfee which we already removed instead?

Fix feedback by adding a unittest in this stack

Rebase to add missing server_tests.cpp file

This should change the release notes.

jasonbcox added a subscriber: jasonbcox.

Talked with Shae offline and we agree this is better to have in the next release. We'll deprecate it again later when the deprecation plan is a little more clear.

This revision is now accepted and ready to land.Nov 7 2018, 17:12
This revision was automatically updated to reflect the committed changes.