Page MenuHomePhabricator

Rename BCLog::DB to BCLog::WALLETDB
AbandonedPublic

Authored by Fabien on Nov 7 2018, 16:39.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Summary

BCLog::DB does not make clear that the log is related to the wallet

Depends on D2016

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
move_BCLogDB
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3805
Build 5684: Bitcoin ABC Buildbot (legacy)
Build 5683: arc lint + arc unit

Event Timeline

jasonbcox added inline comments.
src/logging.cpp
66

I like this change. My only concern is renaming this will break existing logging scripts that specify logging on "db" explicitly.

Two things:

  1. I tested it and using unrecognized debug categories only gives a warning, so operators will not be aware until they realize that logs are missing.
  2. We could provide a legacy "db" category which warns as deprecated. Call out that it is going away in the release notes. Then remove it months later. This may be more overhead than it's worth, but I'd like to know your thoughts.
schancel added inline comments.
src/logging.cpp
66

👍

jasonbcox requested changes to this revision.Nov 13 2018, 04:08
This revision now requires changes to proceed.Nov 13 2018, 04:08
Fabien planned changes to this revision.Dec 21 2018, 16:18