Differential D2032

Fix missing argument in requestedInitialize signal for bitcoin-qt
ClosedPublic
Actions

Authored by Fabien on Nov 9 2018, 13:01.

Details

Reviewers

jasonbcox
schancel
deadalnix

Group Reviewers

Restricted Project

Commits

rSTAGING1570008cf96d: Fix missing argument in requestedInitialize signal for bitcoin-qt
rABC1570008cf96d: Fix missing argument in requestedInitialize signal for bitcoin-qt

Summary

This fixes the `GUI: QObject::connect: No such signal
BitcoinApplication::requestedInitialize(Config *,
HTTPRPCRequestProcessor *)` error encountered on some Linux configs that
caused the software to hang on splash screen with no debug.log.

Test Plan

./src/qt/test/test_bitcoin-qt
bitcoin-qt

Diff Detail

Repository

rABC Bitcoin ABC

Branch

qt_signal_fix

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3820
Build 5713: Bitcoin ABC Buildbot (legacy)
Build 5712: arc lint + arc unit

Event Timeline

Fabien created this revision.Nov 9 2018, 13:01

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 9 2018, 13:01

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3820: Diff 5718.Nov 9 2018, 13:12

deadalnix accepted this revision.Nov 9 2018, 14:11

This revision is now accepted and ready to land.Nov 9 2018, 14:11

jasonbcox accepted this revision.Nov 9 2018, 14:16

Closed by commit rABC1570008cf96d: Fix missing argument in requestedInitialize signal for bitcoin-qt (authored by Fabien). · Explain WhyNov 9 2018, 14:34

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

qt/

bitcoin.cpp

4 lines

Diff 5718

View Options

Fix missing argument in requestedInitialize signal for bitcoin-qtClosedPublicActions