Page MenuHomePhabricator

Cleanup redundant function in abc-p2p-compactblocks
ClosedPublic

Authored by jasonbcox on Mon, Nov 19, 08:29.

Details

Summary

See title. Rehashing the txs is unnecessary because make_conform_to_ctor does this for us.

Co-authored-by: Shammah Chancellor <shammah.chancellor@bitcoinabc.org>

Test Plan

Test passes up to the point where it already fails, so there's that I guess? (we're still working on the test failure for this file; cleaning up helps us focus and move forward)

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jasonbcox created this revision.Mon, Nov 19, 08:29
Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, Nov 19, 08:29
jasonbcox edited the summary of this revision. (Show Details)Mon, Nov 19, 08:30
schancel accepted this revision.Mon, Nov 19, 08:31
This revision is now accepted and ready to land.Mon, Nov 19, 08:31
This revision was automatically updated to reflect the committed changes.