Cleanup redundant function in abc-p2p-compactblocks
ClosedPublic
Actions

Authored by jasonbcox on Nov 19 2018, 08:29.

Details

Reviewers

deadalnix
schancel

Group Reviewers

Restricted Project

Commits

rSTAGING84e5c7f0a0e7: Cleanup redundant function in abc-p2p-compactblocks
rABC84e5c7f0a0e7: Cleanup redundant function in abc-p2p-compactblocks

Summary

See title. Rehashing the txs is unnecessary because make_conform_to_ctor does this for us.

Co-authored-by: Shammah Chancellor <shammah.chancellor@bitcoinabc.org>

Test Plan

Test passes up to the point where it already fails, so there's that I guess? (we're still working on the test failure for this file; cleaning up helps us focus and move forward)

Diff Detail

Repository

rABC Bitcoin ABC

Branch

txinblock (branched from master)

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3994
Build 6060: Bitcoin ABC Buildbot (legacy)
Build 6059: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Nov 19 2018, 08:29

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 19 2018, 08:29

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

jasonbcox edited the summary of this revision. (Show Details)Nov 19 2018, 08:30

schancel accepted this revision.Nov 19 2018, 08:31

This revision is now accepted and ready to land.Nov 19 2018, 08:31

Closed by commit rABC84e5c7f0a0e7: Cleanup redundant function in abc-p2p-compactblocks (authored by jasonbcox). · Explain WhyNov 19 2018, 08:34

This revision was automatically updated to reflect the committed changes.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3994: Diff 5935.Nov 19 2018, 08:37

Revision Contents
Changeset List

Path

Size

test/

functional/

abc-p2p-compactblocks.py

12 lines

Diff 5935

View Options

test/functional/abc-p2p-compactblocks.py

Cleanup redundant function in abc-p2p-compactblocksClosedPublicActions