revert changes to abc-p2p-compactblock.py
ClosedPublic
Actions

Authored by deadalnix on Nov 19 2018, 15:58.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING94fce1408f84: revert changes to abc-p2p-compactblock.py
rABC94fce1408f84: revert changes to abc-p2p-compactblock.py

Summary

Except D2100, for which there isn't much of a problem.

Test Plan

The test still fails, but at least it'll allow to land the fix.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

revertabccompactblocks

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3999
Build 6070: Bitcoin ABC Buildbot (legacy)
Build 6069: arc lint + arc unit

Event Timeline

deadalnix created this revision.Nov 19 2018, 15:58

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 19 2018, 15:58

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B3998: Diff 5942.Nov 19 2018, 16:08

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Actually do it from master

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix added a child revision: D2104: Fix block construction in abc-p2p-compactblocks.py.Nov 19 2018, 16:20

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3999: Diff 5943.Nov 19 2018, 16:21

jasonbcox accepted this revision.Nov 19 2018, 16:23

This revision is now accepted and ready to land.Nov 19 2018, 16:23

Closed by commit rABC94fce1408f84: revert changes to abc-p2p-compactblock.py (authored by deadalnix). · Explain WhyNov 19 2018, 16:24

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

test/

functional/

abc-p2p-compactblocks.py

54 lines

Diff 5943

View Options

test/functional/abc-p2p-compactblocks.py

revert changes to abc-p2p-compactblock.pyClosedPublicActions