Page MenuHomePhabricator

Format pubkey.h and pubkey.cpp
ClosedPublic

Authored by deadalnix on Jun 15 2017, 23:06.

Details

Summary

As per title.

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

freetrader added inline comments.
src/pubkey.h
48 ↗(On Diff #505)

I really dislike this clang-format condensing this onto one line.
Hampers readability as far as I'm concerned.
I don't care about saving a couple of LOC.

Maybe if others feel the same we can do a final pass sometime to reformat these cases onto their own lines, if clang-format can do that.

This revision is now accepted and ready to land.Jun 16 2017, 12:02
src/pubkey.h
48 ↗(On Diff #505)

I would like forcing braces around ifs and alike, but clang-format doesn't know how to do this. clang-format tries to change the code as little as possible and just format. clang-tidy knows how to do these kind of things (and much more), but it is more complicated to integrate. It's on my TODO list, but not hipri enough compared to the HF.

This revision was automatically updated to reflect the committed changes.