Page MenuHomePhabricator

[qa] Fix bip65-cltv-p2p to be compatible with magnetic anomaly
ClosedPublic

Authored by Fabien on Thu, Nov 22, 00:01.

Details

Summary

Make bip65-cltv-p2p compliant with magnetic anomaly rules.
Remove magneticanomalyactivationtime in future and add tx padding when required.

Depends on D2120

Test Plan
./test/functional/test_runner.py bip65-cltv-p2p

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Thu, Nov 22, 00:01
Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, Nov 22, 00:01
Fabien updated this revision to Diff 6005.Thu, Nov 22, 00:04

Fix bad wheel click

deadalnix retitled this revision from [qa] Fix bip65-cltb-p2p to be compatible with magnetic anomaly to [qa] Fix bip65-cltv-p2p to be compatible with magnetic anomaly.Thu, Nov 22, 16:55
deadalnix requested changes to this revision.Thu, Nov 22, 17:13
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
test/functional/bip65-cltv-p2p.py
30 ↗(On Diff #6005)

I don't think this comment is accurate.

32 ↗(On Diff #6005)

Why does -1 causes CLTV to fail ?

62 ↗(On Diff #6005)

These kind of changes are good but tend to clutter the actual meat of the diff. You should make them int heir own diff.

81 ↗(On Diff #6005)

dito

134 ↗(On Diff #6005)

Why ?

This revision now requires changes to proceed.Thu, Nov 22, 17:13
Fabien updated this revision to Diff 6022.Thu, Nov 22, 17:53

Rebase on D2119

Fabien updated this revision to Diff 6030.Thu, Nov 22, 18:35
Fabien marked an inline comment as done.

Rebase on D2120

Fabien updated this revision to Diff 6031.Thu, Nov 22, 18:40

Rebase

deadalnix accepted this revision.Thu, Nov 22, 18:42
This revision is now accepted and ready to land.Thu, Nov 22, 18:42
jasonbcox requested changes to this revision.Fri, Nov 23, 06:25
jasonbcox added a subscriber: jasonbcox.

Looks like D2120 takes care of the meat of these changes. Please update the Summary accordingly.

This revision now requires changes to proceed.Fri, Nov 23, 06:25
Fabien requested review of this revision.Fri, Nov 23, 14:33
Fabien edited the summary of this revision. (Show Details)

Updated summary

test/functional/bip65-cltv-p2p.py
30 ↗(On Diff #6005)

Right, should be anyone can spend, will update

jasonbcox accepted this revision.Sat, Nov 24, 02:58
jasonbcox edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Sat, Nov 24, 02:58
Fabien updated this revision to Diff 6070.Sat, Nov 24, 12:58

Rebase

This revision was automatically updated to reflect the committed changes.