Page MenuHomePhabricator
Differential D2116

[qa] Fix bip65-cltv-p2p to be compatible with magnetic anomaly
ClosedPublic
Actions

Authored by Fabien on Nov 22 2018, 00:01.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING3031ed6fed5f: [qa] Fix bip65-cltv-p2p to be compatible with magnetic anomaly
rABC3031ed6fed5f: [qa] Fix bip65-cltv-p2p to be compatible with magnetic anomaly
Summary

Make bip65-cltv-p2p compliant with magnetic anomaly rules.
Remove magneticanomalyactivationtime in future and add tx padding when required.

Depends on D2120

Test Plan
./test/functional/test_runner.py bip65-cltv-p2p

Diff Detail

Repository
rABC Bitcoin ABC
Branch
bip65py
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4058
Build 6187: Bitcoin ABC Buildbot (legacy)
Build 6186: arc lint + arc unit

Event Timeline

Fabien created this revision.Nov 22 2018, 00:01
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 22 2018, 00:01
Fabien updated this revision to Diff 6005.Nov 22 2018, 00:04

Fix bad wheel click

teamcity added a subscriber: teamcity.Nov 22 2018, 00:09

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Nov 22 2018, 00:18

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Nov 22 2018, 00:18

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B4044: Diff 6004!Nov 22 2018, 00:18
teamcity added a comment.Nov 22 2018, 00:26

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4045: Diff 6005.Nov 22 2018, 00:26
deadalnix retitled this revision from [qa] Fix bip65-cltb-p2p to be compatible with magnetic anomaly to [qa] Fix bip65-cltv-p2p to be compatible with magnetic anomaly.Nov 22 2018, 16:55
deadalnix requested changes to this revision.Nov 22 2018, 17:13
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
test/functional/bip65-cltv-p2p.py
30 ↗(On Diff #6005)

I don't think this comment is accurate.

32 ↗(On Diff #6005)

Why does -1 causes CLTV to fail ?

62 ↗(On Diff #6005)

These kind of changes are good but tend to clutter the actual meat of the diff. You should make them int heir own diff.

81 ↗(On Diff #6005)

dito

134 ↗(On Diff #6005)

Why ?

This revision now requires changes to proceed.Nov 22 2018, 17:13
Fabien updated this revision to Diff 6022.Nov 22 2018, 17:53

Rebase on D2119

Fabien updated this revision to Diff 6030.Nov 22 2018, 18:35
Fabien marked an inline comment as done.

Rebase on D2120

Fabien updated this revision to Diff 6031.Nov 22 2018, 18:40

Rebase

deadalnix accepted this revision.Nov 22 2018, 18:42
This revision is now accepted and ready to land.Nov 22 2018, 18:42
teamcity added a comment.Nov 22 2018, 19:49

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Nov 22 2018, 19:58

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4058: Diff 6022.Nov 22 2018, 19:58
teamcity added a comment.Nov 22 2018, 20:27

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Nov 22 2018, 20:29

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Nov 22 2018, 20:36

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4062: Diff 6030.Nov 22 2018, 20:37
teamcity added a comment.Nov 22 2018, 20:37

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4063: Diff 6031.Nov 22 2018, 20:38
jasonbcox requested changes to this revision.Nov 23 2018, 06:25
jasonbcox added a subscriber: jasonbcox.

Looks like D2120 takes care of the meat of these changes. Please update the Summary accordingly.

This revision now requires changes to proceed.Nov 23 2018, 06:25
Fabien requested review of this revision.Nov 23 2018, 14:33
Fabien edited the summary of this revision. (Show Details)
Fabien added a parent revision: D2120: Move CLTV from scriptSig to scriptPubKey in bip65-cltv-p2p.py.

Updated summary

test/functional/bip65-cltv-p2p.py
30 ↗(On Diff #6005)

Right, should be anyone can spend, will update

jasonbcox accepted this revision.Nov 24 2018, 02:58
jasonbcox edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Nov 24 2018, 02:58
Fabien updated this revision to Diff 6070.Nov 24 2018, 12:58

Rebase

Closed by commit rABC3031ed6fed5f: [qa] Fix bip65-cltv-p2p to be compatible with magnetic anomaly (authored by Fabien). · Explain WhyNov 24 2018, 12:59
This revision was automatically updated to reflect the committed changes.
teamcity added a comment.Nov 24 2018, 12:59

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Nov 24 2018, 13:08

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4095: Diff 6070.Nov 24 2018, 13:08

Revision Contents
Changeset List

PathSize
test/
functional/
123 lines

Diff 6022

View Options

test/functional/bip65-cltv-p2p.py

Loading...