Page MenuHomePhabricator

Move finalization suck as reconsiderblock actualy reconsider blocks
ClosedPublic

Authored by deadalnix on Nov 22 2018, 16:53.

Details

Summary

Right now, if we reconsider a block that has been excluded due to finalization, this block will immediately get excluded again and not actually be reconsidered.

To ensure it is, move the finalization to the last common ancestor betweent he finalized block and the reconsidered block before reconsidering.

Test Plan

Added integration test.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Nov 22 2018, 17:25

Add an wrapper to check for finalization.

This revision was automatically updated to reflect the committed changes.