Page MenuHomePhabricator

Fix undefined behaviour errors due to long int overflow in Amount
ClosedPublic

Authored by Fabien on Dec 7 2018, 14:53.

Details

Summary

Running the units tests with the undefined behaviour sanitizer throws
runtime errors: signed integer overflow in file amount.h.
This is due to the INF_PRIORITY constant, which is no longer used in the
software. It can be safely removed.

Test Plan

Build with the undefined sanitizer enabled then

./src/test/test_bitcoin

Diff Detail

Repository
rABC Bitcoin ABC
Branch
ubsan_amount_fix
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 4276
Build 6617: Bitcoin ABC Buildbot (legacy)
Build 6616: arc lint + arc unit

Event Timeline

Fabien created this revision.Dec 7 2018, 14:53
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 7 2018, 14:53
Herald added a subscriber: schancel. · View Herald Transcript
deadalnix accepted this revision.Dec 7 2018, 20:00
This revision is now accepted and ready to land.Dec 7 2018, 20:00
This revision was automatically updated to reflect the committed changes.