Fix undefined behaviour errors due to long int overflow in Amount
ClosedPublic
Actions

Authored by Fabien on Dec 7 2018, 14:53.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING7cc44b87c1f3: Fix undefined behaviour errors due to long int overflow in Amount
rABC7cc44b87c1f3: Fix undefined behaviour errors due to long int overflow in Amount

Summary

Running the units tests with the undefined behaviour sanitizer throws
runtime errors: signed integer overflow in file amount.h.
This is due to the INF_PRIORITY constant, which is no longer used in the
software. It can be safely removed.

Test Plan

Build with the undefined sanitizer enabled then

./src/test/test_bitcoin

Diff Detail

Repository

rABC Bitcoin ABC

Branch

ubsan_amount_fix

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4276
Build 6617: Bitcoin ABC Buildbot (legacy)
Build 6616: arc lint + arc unit

Event Timeline

Fabien created this revision.Dec 7 2018, 14:53

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 7 2018, 14:53

Herald added a reviewer: deadalnix. · View Herald Transcript

Herald added a subscriber: schancel. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4276: Diff 6292.Dec 7 2018, 15:03

deadalnix accepted this revision.Dec 7 2018, 20:00

This revision is now accepted and ready to land.Dec 7 2018, 20:00

Closed by commit rABC7cc44b87c1f3: Fix undefined behaviour errors due to long int overflow in Amount (authored by Fabien). · Explain WhyDec 7 2018, 20:51

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

policy/

fees.h

1 line

Diff 6292

View Options

Fix undefined behaviour errors due to long int overflow in AmountClosedPublicActions