Fix re-use of BITCOIN_CONFIG_H (collision between two headers)
AbandonedPublic
Actions

Authored by freetrader on Jun 18 2017, 13:27.

Details

Reviewers

deadalnix
sickpig
kyuupichan
awemany

Group Reviewers

Restricted Project

Summary

Fix what appears to be a collision of header guards.

This appears to resolve a build problem which lead to compilation problems
on bitcoind.cpp (where GetConfig() was reported as not declared in scope).
The build problem was observed using more recent compiler (gcc 7.1.0),
and resolved itself when the src/config.h header conditional was made
unique.
It is not clear why this collision does not manifest itself under all
circumstances (e.g. not when building with gcc 4.9.2).
The test system was a Debian 8 derivative (x86_64).

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

fix_colliding_header_ifndef

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 328
Build 328: arc lint + arc unit

Event Timeline

freetrader created this revision.Jun 18 2017, 13:27

Herald added 1 blocking reviewer(s): Restricted Project. · View Herald TranscriptJun 18 2017, 13:27

Harbormaster completed remote builds in B328: Diff 538.Jun 18 2017, 13:27

What does conflict ?

Requesting change until what's conflicting is figured out.

This revision now requires changes to proceed.Jun 19 2017, 05:46

This issue was most likely caused by a local configuration problem, therefore I am withdrawing the change.

I will propose a better change instead, to rename the BITCOIN_BITCOIN_CONFIG_H symbol into BITCOIN_AUTO_CONFIG_H to make it clear that it is an auto-generated header.

Revision Contents
Changeset List

Path

Size

src/

config.h

5 lines

Diff 538

View Options

Fix re-use of BITCOIN_CONFIG_H (collision between two headers)AbandonedPublicActions