qt: Make sure splash screen is freed on AppInitMain fail
ClosedPublic
Actions

Authored by Fabien on Dec 15 2018, 20:16.

Details

Reviewers

deadalnix
jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGING2296ccc6ec4c: qt: Make sure splash screen is freed on AppInitMain fail
rABC2296ccc6ec4c: qt: Make sure splash screen is freed on AppInitMain fail

Summary

Backport of core PR12374

Test Plan

Launch bitcoin-qt and closes the splash screen exactly at the end of the
AppInitMain process (refer to core issue #12372)

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR12374

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4315
Build 6695: Bitcoin ABC Buildbot (legacy)
Build 6694: arc lint + arc unit

Event Timeline

Fabien created this revision.Dec 15 2018, 20:16

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 15 2018, 20:16

Herald added a reviewer: deadalnix. · View Herald Transcript

Herald added a subscriber: schancel. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4315: Diff 6345.Dec 15 2018, 20:26

jasonbcox accepted this revision.Dec 19 2018, 02:27

This revision is now accepted and ready to land.Dec 19 2018, 02:27

Closed by commit rABC2296ccc6ec4c: qt: Make sure splash screen is freed on AppInitMain fail (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by Fabien). · Explain WhyDec 19 2018, 10:50

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

qt/

bitcoin.cpp

6 lines

Diff 6345

View Options

qt: Make sure splash screen is freed on AppInitMain failClosedPublicActions