Page MenuHomePhabricator
Differential D2196

[qt] navigate to transaction history page after send
ClosedPublic
Actions

Authored by Fabien on Dec 15 2018, 21:16.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING180f758143ef: [qt] navigate to transaction history page after send
rABC180f758143ef: [qt] navigate to transaction history page after send
Summary

Backport from core PR12421

Test Plan

Launch bitcoin-qt and send a transaction

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR12421
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4329
Build 6723: Bitcoin ABC Buildbot (legacy)
Build 6722: arc lint + arc unit

Event Timeline

Fabien created this revision.Dec 15 2018, 21:16
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 15 2018, 21:16
Herald added a reviewer: deadalnix. · View Herald Transcript
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Dec 15 2018, 21:18

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Dec 15 2018, 21:26

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B4317: Diff 6347!Dec 15 2018, 21:27
teamcity added a comment.Dec 15 2018, 21:32

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Dec 15 2018, 21:40

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4317: Diff 6347.Dec 15 2018, 21:40
jasonbcox requested changes to this revision.Dec 19 2018, 02:32
jasonbcox added a subscriber: jasonbcox.

One nit. Looks good otherwise.

src/qt/transactionview.cpp
630 ↗(On Diff #6347)

Fix errant newline in the middle of the comment block

This revision now requires changes to proceed.Dec 19 2018, 02:32
Fabien updated this revision to Diff 6359.Dec 19 2018, 10:47

Fix comment layout

teamcity added a comment.Dec 19 2018, 18:16

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Dec 19 2018, 18:23

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4329: Diff 6359.Dec 19 2018, 18:23
jasonbcox accepted this revision.Dec 19 2018, 23:55
This revision is now accepted and ready to land.Dec 19 2018, 23:55
Closed by commit rABC180f758143ef: [qt] navigate to transaction history page after send (authored by Sjors Provoost <sjors@sprovoost.nl>, committed by Fabien). · Explain WhyDec 21 2018, 12:04
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 6359

View Options

src/qt/bitcoin.cpp

Loading...
View Options

src/qt/sendcoinsdialog.h

Loading...
View Options

src/qt/sendcoinsdialog.cpp

Loading...
View Options

src/qt/transactionview.h

Loading...
View Options

src/qt/transactionview.cpp

Loading...
View Options

src/qt/walletview.cpp

Loading...