Details
- Reviewers
deadalnix - Group Reviewers
Restricted Project - Commits
- rSTAGING6ce7c7d765f2: Integrate the string format linter with arcanist
rABC6ce7c7d765f2: Integrate the string format linter with arcanist
Modify some files with a string format error and run arc lint.
Check that the error is catched by the linter.
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- arcanist_format_linter
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 4365 Build 6795: Bitcoin ABC Buildbot (legacy) Build 6794: arc lint + arc unit
Event Timeline
| test/lint/lint-format-strings.sh | ||
|---|---|---|
| 37 ↗ | (On Diff #6413) | Because arcanist will check each file individually, exit should return non zero. Otherwise when a lint error occurs arcanist will stop with a script error instead of parsing the output and process the next files. |
| test/lint/lint-format-strings.sh | ||
|---|---|---|
| 30 ↗ | (On Diff #6413) | Why the change ? |
| test/lint/lint-format-strings.sh | ||
|---|---|---|
| 30 ↗ | (On Diff #6413) | If you fail the test, why would you run a defective linter ? |
The test plan is not adequate. To check that linter works properly require to actually trigger an error and see that it's reported properly.
| test/lint/lint-format-strings.sh | ||
|---|---|---|
| 30 ↗ | (On Diff #6413) | Will it break something if I do? |
The linter internal tests actually check that the linter internal functions are working as expected, but I agree there is no test on the linter whole chain. I will add these tests.
| test/lint/lint-format-strings.sh | ||
|---|---|---|
| 30 ↗ | (On Diff #6413) | It will not prevent it from running with arcanist, but may eventually flood the output with false detection, making it harder to figure out that the linter itself failed. |
| test/lint/lint-format-strings.sh | ||
|---|---|---|
| 35 | A non zero return tells arcanist that the script failed to execute, and stop the linting process without parsing the output for linter error. | |