Page MenuHomePhabricator

Improve tests for the string format linter
ClosedPublic

Authored by Fabien on Dec 26 2018, 20:17.

Details

Summary

Add high level doctests to check that detection is working as expected.

Depends on D2025

Test Plan
python3 -m doctest -v test/lint/lint-format-strings.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Dec 26 2018, 20:17
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 26 2018, 20:17
Herald added a subscriber: schancel. · View Herald Transcript
deadalnix requested changes to this revision.Dec 27 2018, 23:45
deadalnix added inline comments.
test/lint/lint-format-strings-tests-skip-arguments.txt
1 ↗(On Diff #6424)

Why is that file executable?

test/lint/lint-format-strings-tests.txt
1 ↗(On Diff #6424)

dito

This revision now requires changes to proceed.Dec 27 2018, 23:45
Fabien updated this revision to Diff 6434.Dec 28 2018, 10:17

Fix txt files permissions

Fabien added inline comments.Dec 28 2018, 10:25
test/lint/lint-format-strings-tests-skip-arguments.txt
1 ↗(On Diff #6424)

Good catch, I missed some WSL limitation here

deadalnix accepted this revision.Dec 30 2018, 12:03
This revision is now accepted and ready to land.Dec 30 2018, 12:03
This revision was automatically updated to reflect the committed changes.