Page MenuHomePhabricator
Differential D2225

Improve tests for the string format linter
ClosedPublic
Actions

Authored by Fabien on Dec 26 2018, 20:17.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING5c7d4be1cb12: Improve tests for the string format linter
rABC5c7d4be1cb12: Improve tests for the string format linter
Summary

Add high level doctests to check that detection is working as expected.

Depends on D2025

Test Plan
python3 -m doctest -v test/lint/lint-format-strings.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
linter_string_format_add_tests
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4364
Build 6793: Bitcoin ABC Buildbot (legacy)
Build 6792: arc lint + arc unit

Event Timeline

Fabien created this revision.Dec 26 2018, 20:17
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 26 2018, 20:17
Herald added a reviewer: deadalnix. · View Herald Transcript
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Dec 26 2018, 20:20

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Dec 26 2018, 20:28

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4364: Diff 6424.Dec 26 2018, 20:28
Fabien added a child revision: D2218: Integrate the string format linter with arcanist.Dec 27 2018, 16:11
deadalnix requested changes to this revision.Dec 27 2018, 23:45
deadalnix added inline comments.
test/lint/lint-format-strings-tests-skip-arguments.txt
1

Why is that file executable?

test/lint/lint-format-strings-tests.txt
1

dito

This revision now requires changes to proceed.Dec 27 2018, 23:45
Fabien updated this revision to Diff 6434.Dec 28 2018, 10:17

Fix txt files permissions

teamcity added a comment.Dec 28 2018, 10:20

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fabien added inline comments.Dec 28 2018, 10:25
test/lint/lint-format-strings-tests-skip-arguments.txt
1

Good catch, I missed some WSL limitation here

teamcity added a comment.Dec 28 2018, 10:28

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4370: Diff 6434.Dec 28 2018, 10:28
deadalnix accepted this revision.Dec 30 2018, 12:03
This revision is now accepted and ready to land.Dec 30 2018, 12:03
Closed by commit rABC5c7d4be1cb12: Improve tests for the string format linter (authored by Fabien). · Explain WhyDec 30 2018, 13:45
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 6424

View Options

test/lint/lint-format-strings-tests-skip-arguments.txt

Loading...
View Options

test/lint/lint-format-strings-tests.txt

Loading...
View Options

test/lint/lint-format-strings.py

Loading...