Page MenuHomePhabricator

Improve tests for the string format linter
ClosedPublic

Authored by Fabien on Dec 26 2018, 20:17.

Details

Summary

Add high level doctests to check that detection is working as expected.

Depends on D2025

Test Plan
python3 -m doctest -v test/lint/lint-format-strings.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
linter_string_format_add_tests
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4364
Build 6793: Bitcoin ABC Buildbot (legacy)
Build 6792: arc lint + arc unit

Event Timeline

deadalnix requested changes to this revision.Dec 27 2018, 23:45
deadalnix added inline comments.
test/lint/lint-format-strings-tests-skip-arguments.txt
1

Why is that file executable?

test/lint/lint-format-strings-tests.txt
1

dito

This revision now requires changes to proceed.Dec 27 2018, 23:45

Fix txt files permissions

test/lint/lint-format-strings-tests-skip-arguments.txt
1

Good catch, I missed some WSL limitation here

This revision is now accepted and ready to land.Dec 30 2018, 12:03
This revision was automatically updated to reflect the committed changes.