Page MenuHomePhabricator

Fix getbestblockhash() called before the tip reaches the expected block
ClosedPublic

Authored by Fabien on Dec 23 2018, 13:32.

Details

Summary

This fix a bug raised on CI (Teamcity #3004).
Analyzing the log shown that delay_node.getbestblockhash() was called
before its tip has been updated to alt_node_new_tip, which occured 3ms
later. Waiting for the tip to settle should avoid the issue.

Test Plan
./test/functional/test_runner.py abc-finalize-block

Diff Detail

Repository
rABC Bitcoin ABC
Branch
finalize_block_delay_node_fix
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4360
Build 6785: Bitcoin ABC Buildbot (legacy)
Build 6784: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Dec 23 2018, 14:44
This revision was automatically updated to reflect the committed changes.