Fix header guards using reserved identifiers
ClosedPublic
Actions

Authored by Fabien on Dec 29 2018, 17:24.

Details

Reviewers

deadalnix
jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGING3627c9ecaa38: Fix header guards using reserved identifiers
rABC3627c9ecaa38: Fix header guards using reserved identifiers

Summary

Identifiers beginning with an underscore followed immediately by an
uppercase letter are reserved.

Backport of core PR11151

Test Plan

make

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR11151

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4381
Build 6827: Bitcoin ABC Buildbot (legacy)
Build 6826: arc lint + arc unit

Event Timeline

Fabien created this revision.Dec 29 2018, 17:24

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 29 2018, 17:24

Herald added a reviewer: deadalnix. · View Herald Transcript

Herald added a subscriber: schancel. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4381: Diff 6447.Dec 29 2018, 17:39

jasonbcox accepted this revision.Dec 29 2018, 17:50

This revision is now accepted and ready to land.Dec 29 2018, 17:50

Closed by commit rABC3627c9ecaa38: Fix header guards using reserved identifiers (authored by Dan Raviv <dan@soundradix.com>, committed by Fabien). · Explain WhyDec 29 2018, 21:00

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

cuckoocache.h

6 lines

Diff 6447

View Options

Fix header guards using reserved identifiersClosedPublicActions