Differential D2250

Add a local variable for the rpc port
ClosedPublic
Actions

Authored by deadalnix on Jan 3 2019, 12:17.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rSTAGING951cef9ded2a: Add a local variable for the rpc port
rABC951cef9ded2a: Add a local variable for the rpc port

Summary

This ensure that we can get rid recomputing the port number based on state that comes from outside the TestNode instance.

Test Plan

./test/functional/test_runner.py --extended

Diff Detail

Repository

rABC Bitcoin ABC

Branch

rpcportdeglobal

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4404
Build 6873: Bitcoin ABC Buildbot (legacy)
Build 6872: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jan 3 2019, 12:17

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 3 2019, 12:17

Herald added a subscriber: schancel. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4404: Diff 6490.Jan 3 2019, 12:50

Fabien accepted this revision.Jan 3 2019, 14:20

This revision is now accepted and ready to land.Jan 3 2019, 14:20

Closed by commit rABC951cef9ded2a: Add a local variable for the rpc port (authored by deadalnix). · Explain WhyJan 3 2019, 21:20

This revision was automatically updated to reflect the committed changes.

deadalnix mentioned this in D2159: [Part 1 of 4] [qa] De-globalize port seeding.Jan 3 2019, 21:56

Revision Contents
Changeset List

Path

Size

test/

functional/

test_framework/

test_framework.py

5 lines

test_node.py

3 lines

Diff 6490

View Options

test/functional/test_framework/test_framework.py