Paths

Table of Contentst

Remove unused error code and ensure SCRIPT_ERR_CLEANSTACK has an associated error message
ClosedPublic
Actions

Authored by deadalnix on Jun 19 2017, 17:28.

Details

Reviewers

freetrader
sickpig
awemany
kyuupichan

Group Reviewers

Restricted Project

Commits

rSTAGING786073eae222: Remove unused error code and ensure SCRIPT_ERR_CLEANSTACK has an associated…
rABC786073eae222: Remove unused error code and ensure SCRIPT_ERR_CLEANSTACK has an associated…

Summary

After a long session of debugging, it turns out CLEANSTACK has no error message...

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Jun 19 2017, 17:28

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 19 2017, 17:28

Harbormaster completed remote builds in B347: Diff 561.Jun 19 2017, 17:28

Remove leftovers

Harbormaster completed remote builds in B348: Diff 562.Jun 19 2017, 17:41

Builds and passes make check, change looks sensible to me.

freetrader accepted this revision.Jun 19 2017, 20:02

This revision is now accepted and ready to land.Jun 19 2017, 20:02

Closed by commit rABC786073eae222: Remove unused error code and ensure SCRIPT_ERR_CLEANSTACK has an associated… (authored by deadalnix, committed by deadalnix). · Explain WhyJun 19 2017, 20:04

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

script/

script_error.h

8 lines

script_error.cpp

14 lines

test/

script_tests.cpp

6 lines

Diff 575

View Options

src/script/script_error.h

View Options

src/script/script_error.cpp

View Options

Remove unused error code and ensure SCRIPT_ERR_CLEANSTACK has an associated error messageClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 575

src/script/script_error.h

src/script/script_error.cpp

src/test/script_tests.cpp

Remove unused error code and ensure SCRIPT_ERR_CLEANSTACK has an associated error message
ClosedPublic
Actions

Revision Contents
Changeset List