Page MenuHomePhabricator
Differential D2301

Fix version information in seeder documentation
ClosedPublic
Actions

Authored by Mengerian on Jan 14 2019, 05:33.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING072b4f327482: Fix version information in seeder documentation
rABC072b4f327482: Fix version information in seeder documentation
Summary

Information on versions was referring to Bitcoin Core.
Replace with applicable Bitcoin Cash information.

Test Plan

read to check the information is accurate

Diff Detail

Repository
rABC Bitcoin ABC
Branch
seeder-nits
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4499
Build 7061: Bitcoin ABC Buildbot (legacy)
Build 7060: arc lint + arc unit

Event Timeline

Mengerian created this revision.Jan 14 2019, 05:33
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 14 2019, 05:33
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Jan 14 2019, 05:35

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jan 14 2019, 05:44

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4499: Diff 6634.Jan 14 2019, 05:44
Mengerian updated this revision to Diff 6635.Jan 14 2019, 05:50

fix typo

teamcity added a comment.Jan 14 2019, 05:52

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jan 14 2019, 06:01

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4500: Diff 6635.Jan 14 2019, 06:01
deadalnix requested changes to this revision.Jan 14 2019, 16:26
deadalnix added inline comments.
src/seeder/README.md
14 ↗(On Diff #6635)

We should deprecate NODE_BITCOIN_CASH, no I'm not sure how relevant it is to keep it in the doc.

This revision now requires changes to proceed.Jan 14 2019, 16:26
Mengerian updated this revision to Diff 6649.Jan 14 2019, 16:58

Remove mention of NODE_BITCOIN_CASH, which should be deprecated
and is no longer relevant.

Mengerian marked an inline comment as done.Jan 14 2019, 16:58
teamcity added a comment.Jan 14 2019, 17:00

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Mengerian updated this revision to Diff 6650.Jan 14 2019, 17:00

Simplify wording further

teamcity added a comment.Jan 14 2019, 17:02

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix accepted this revision.Jan 14 2019, 17:07
This revision is now accepted and ready to land.Jan 14 2019, 17:07
teamcity added a comment.Jan 14 2019, 17:08

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4511: Diff 6649.Jan 14 2019, 17:08
teamcity added a comment.Jan 14 2019, 17:11

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4512: Diff 6650.Jan 14 2019, 17:11
Closed by commit rABC072b4f327482: Fix version information in seeder documentation (authored by Mengerian). · Explain WhyJan 14 2019, 17:16
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
seeder/
11 lines

Diff 6634

View Options

src/seeder/README.md

Loading...