Documentation referred to Bitcoin Core procedure. Update
to process applicable to Bitcoin ABC
Details
Details
- Reviewers
deadalnix - Group Reviewers
Restricted Project - Commits
- rSTAGING5ec77822cc26: Improve documentation for seed list generation
rABC5ec77822cc26: Improve documentation for seed list generation
Read to ensure step correspond to what is actually done.
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- seed-test
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 4553 Build 7169: Bitcoin ABC Buildbot (legacy) Build 7168: arc lint + arc unit
Event Timeline
| contrib/seeds/README.md | ||
|---|---|---|
| 15 ↗ | (On Diff #6636) | Please don't assume path, especially a relative path. Especially since it is unlikely that someone will run the seeder for 30 days straight on a devbox. Most likely this file is coming from somewhere else. |
| 18 ↗ | (On Diff #6636) | The path will be dependent on one's setup. You should keep the simple filename. |
| src/seeder/README.md | ||
| 29 ↗ | (On Diff #6636) | This isn't really the goal of the seeder though. It is to bootstrap new nodes via DNS. What's more important should come first. |
| 32 ↗ | (On Diff #6636) | Please do not write thing assuming directories, especially relative ones. |
| contrib/seeds/README.md | ||
|---|---|---|
| 18 ↗ | (On Diff #6636) | OK. the only issues is that testnet and mainnet seeders generate the same file name. So that makes it confusing to explain in the documentation. |
Comment Actions
Remove relative paths
Move list generation use of seeder to end of the document,
since it is not the primary purpose of the seeder.
Comment Actions
Remove some commands. The commands that I had added to generate seed
lists were too specific and may just add confusion if the lists
come from a long-running DNS seeder such as seed.bitcoinabc.org