Page MenuHomePhabricator
Differential D2306

Make check-doc.py compliant to python3
ClosedPublic
Actions

Authored by Fabien on Jan 14 2019, 12:21.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING9a00f6874b71: Make check-doc.py compliant to python3
rABC9a00f6874b71: Make check-doc.py compliant to python3
Summary

check_output returns bytes but the regex is using a string.
The decode() method will convert from bytes to string.

Depends on D2305

Test Plan
python2 ./test/lint/check-doc.py
python3 ./test/lint/check-doc.py

Check the outputs are the same

Diff Detail

Repository
rABC Bitcoin ABC
Branch
check_doc_python3
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4505
Build 7073: Bitcoin ABC Buildbot (legacy)
Build 7072: arc lint + arc unit

Event Timeline

Fabien created this revision.Jan 14 2019, 12:21
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 14 2019, 12:21
Herald added a reviewer: deadalnix. · View Herald Transcript
Herald added a subscriber: schancel. · View Herald Transcript
Fabien edited the summary of this revision. (Show Details)Jan 14 2019, 12:22
Fabien added a parent revision: D2305: Move check-doc.py from contrib/devtools to test/lint.
teamcity added a subscriber: teamcity.Jan 14 2019, 12:23

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fabien added a child revision: D2307: Integrates the check-doc.py script to arcanist.Jan 14 2019, 12:26
teamcity added a comment.Jan 14 2019, 12:32

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4505: Diff 6640.Jan 14 2019, 12:32
deadalnix accepted this revision.Jan 14 2019, 16:35
This revision is now accepted and ready to land.Jan 14 2019, 16:35
Closed by commit rABC9a00f6874b71: Make check-doc.py compliant to python3 (authored by Fabien). · Explain WhyJan 22 2019, 17:10
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rSTAGING9a00f6874b71: Make check-doc.py compliant to python3.Sep 18 2019, 22:00

Revision Contents
Changeset List

PathSize
test/
lint/
8 lines

Diff 6640

View Options

test/lint/check-doc.py

Loading...