Page MenuHomePhabricator

Remove magnetic anomaly transitional code, activate on block height
ClosedPublic

Authored by Fabien on Jan 15 2019, 19:52.

Details

Summary

This include the -magneticanomalyactivationtime parameter and some
functional tests.

Depends on D2324

Test Plan
make check
./test/functional/test_runner.py

Run IBD with checkpoint disabled and assumevalid=0 on mainnet and testnet

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Jan 15 2019, 19:52
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 15 2019, 19:52
Herald added a subscriber: schancel. · View Herald Transcript
deadalnix requested changes to this revision.Jan 15 2019, 20:53

You should also remove the mempool clearing code when we reorg accross the fork.

src/consensus/activation.h
20 ↗(On Diff #6676)

int32_t

src/consensus/tx_verify.cpp
41 ↗(On Diff #6676)

Why ?

test/functional/abc-replay-protection.py
110 ↗(On Diff #6676)

It's a good idea to do these in their own patches. It's easy wins that won't get blocked by anything else.

test/functional/abc-transaction-ordering.py
20 ↗(On Diff #6676)

dito

This revision now requires changes to proceed.Jan 15 2019, 20:53
Fabien updated this revision to Diff 6690.Jan 16 2019, 10:02

Split commit (python tests are updated in D2324)
int => int32_t
Update transaction unit tests instead of removing them

Fabien added a comment.Jan 16 2019, 10:04

@deadalnix Didn't you already removed the mempool clearing code in D2213 ? Or are you talking about something else ?

deadalnix requested changes to this revision.Jan 17 2019, 01:00
In D2318#52425, @Fabien wrote:

@deadalnix Didn't you already removed the mempool clearing code in D2213 ? Or are you talking about something else ?

Absolutely, my bad. You are all set.

src/chainparams.cpp
303 ↗(On Diff #6690)
This revision now requires changes to proceed.Jan 17 2019, 01:00

The test plan for this change should definitively include an IBD with checkpoint disabled and assumevalid=0 for both mainnet and testnet.

Fabien edited the test plan for this revision. (Show Details)Jan 17 2019, 07:19
Fabien edited the test plan for this revision. (Show Details)
Fabien updated this revision to Diff 6707.Jan 17 2019, 07:24

Fix fork block height on testnet

deadalnix requested changes to this revision.Jan 17 2019, 17:03

Please do run these IBD on mainnet and testnet.

This revision now requires changes to proceed.Jan 17 2019, 17:03
Fabien edited the summary of this revision. (Show Details)Jan 17 2019, 18:10

IBD on testnet is OK, still running on mainet.
I will request for review when it's done

Fabien requested review of this revision.Jan 18 2019, 10:38

IBD on both testnet and mainnet were successful with the following parameters:
-checkpoints=0 -assumevalid=0

Fabien updated this revision to Diff 6722.Jan 18 2019, 12:59

Fix testnet block height

It seems tome that both height are off by one.

Fabien planned changes to this revision.Sat, Jan 19, 17:53
Fabien updated this revision to Diff 6821.Tue, Jan 22, 15:02

Fix block height for mainnet and testnet

deadalnix accepted this revision.Tue, Jan 22, 15:06
This revision is now accepted and ready to land.Tue, Jan 22, 15:06
Fabien updated this revision to Diff 6824.Tue, Jan 22, 15:45

Rebase

This revision was automatically updated to reflect the committed changes.