Page MenuHomePhabricator
Differential D2320

Merge #10303: [bench] Include ms/blk stats in Connect* benchmarks.
ClosedPublic
Actions

Authored by jasonbcox on Jan 15 2019, 22:36.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGINGa801f7806bd0: Merge #10303: [bench] Include ms/blk stats in Connect* benchmarks.
rABCa801f7806bd0: Merge #10303: [bench] Include ms/blk stats in Connect* benchmarks.
Summary

a473eff [bench] Replace 0.00(000)1 with MICRO/MILLI #defines in validation.cpp. (Karl-Johan Alm)
5f850b0 [bench] Include ms/blk stats in Connect* benchmarks. (Karl-Johan Alm)

Pull request description:

Display the average per block runtime for the various benchmarked times in the block connect functions to give an overview of long(er) term time distribution statistics.

Tree-SHA512: 3d6f24f6b9e3dbb448a647e2cda8e7b90ad6a16d4821f49f426a8e1ebc3ce5a0cf0a8cde82213e293affba441615702dfe50822c8c818e282af03bfe383d83e0

Backport of Core PR10303
Completes T520

Test Plan
ninja
bitcoind

Verify debug.log output matches new format.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jasonbcox created this revision.Jan 15 2019, 22:36
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 15 2019, 22:36
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Jan 15 2019, 22:38

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

jasonbcox added a child revision: D2321: Document assumptions that are being made to avoid NULL pointer dereferences.Jan 15 2019, 22:43
teamcity added a comment.Jan 15 2019, 22:47

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4536: Diff 6684.Jan 15 2019, 22:47
deadalnix requested changes to this revision.Jan 16 2019, 00:42

Use PR10303 so it can be grepped for.

This revision now requires changes to proceed.Jan 16 2019, 00:42
jasonbcox requested review of this revision.Jan 16 2019, 01:15
jasonbcox edited the summary of this revision. (Show Details)
Fabien accepted this revision.Jan 16 2019, 16:28
deadalnix accepted this revision.Jan 17 2019, 00:54
This revision is now accepted and ready to land.Jan 17 2019, 00:54
Closed by commit rABCa801f7806bd0: Merge #10303: [bench] Include ms/blk stats in Connect* benchmarks. (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by jasonbcox). · Explain WhyJan 17 2019, 17:16
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
83 lines

Diff 6714

View Options

src/validation.cpp

Loading...