Page MenuHomePhabricator
Differential D2330

[Part 4] [tests] Add P2P interface to TestNode
ClosedPublic
Actions

Authored by Fabien on Jan 16 2019, 15:35.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGINGeace3ae2f8da: [Part 4] [tests] Add P2P interface to TestNode
rABCeace3ae2f8da: [Part 4] [tests] Add P2P interface to TestNode
Summary

Partial backport of core PR11182 (commit 32ae82f)

Update the tests to the new P2P interface

Depends on D2326

Test Plan
./test/functional/test_runner.py p2p-mempool p2p-timeouts

sendheaders

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Jan 16 2019, 15:35
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 16 2019, 15:35
Herald added a reviewer: deadalnix. · View Herald Transcript
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Jan 16 2019, 15:41

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jan 16 2019, 15:49

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4550: Diff 6698.Jan 16 2019, 15:49
jasonbcox requested changes to this revision.Jan 17 2019, 00:49
jasonbcox added a subscriber: jasonbcox.

Please make sure to apply these same changes to the abc-* integration tests. I'm certain a number of them will require the new add_p2p_connection() and friends.

test/functional/sendheaders.py
234 ↗(On Diff #6698)

services=0 since there's no segwit

This revision now requires changes to proceed.Jan 17 2019, 00:49
Fabien updated this revision to Diff 6709.Jan 17 2019, 08:04

Remove Segwit from services

teamcity added a comment.Jan 17 2019, 08:06

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jan 17 2019, 08:14

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4560: Diff 6709.Jan 17 2019, 08:14
jasonbcox accepted this revision.Jan 17 2019, 23:35
This revision is now accepted and ready to land.Jan 17 2019, 23:35
Closed by commit rABCeace3ae2f8da: [Part 4] [tests] Add P2P interface to TestNode (authored by Fabien). · Explain WhyJan 18 2019, 13:13
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
test/
functional/
12 lines
48 lines
22 lines

Diff 6728

View Options

test/functional/p2p-mempool.py

Loading...
View Options

test/functional/p2p-timeouts.py

Loading...
View Options

test/functional/sendheaders.py

Loading...