Page MenuHomePhabricator

Merge #10165: [Wallet] Refactoring by using CInputCoin instead of std::pair
ClosedPublic

Authored by jasonbcox on Jan 17 2019, 19:17.

Details

Summary

Backport of Core PR10165
https://github.com/bitcoin/bitcoin/pull/10165/files

Completes T523

Co-authored-by: Jason B. Cox <contact@jasonbcox.com>

Test Plan

ninja check
make check
bitcoin-qt loads and can send transactions as expected

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr10165
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4564
Build 7191: Bitcoin ABC Buildbot (legacy)
Build 7190: arc lint + arc unit

Event Timeline

jasonbcox retitled this revision from [Wallet] Rename std::pair<const CWalletTx*, unsigned int> to CInputCoin to Merge #10165: [Wallet] Refactoring by using CInputCoin instead of std::pair.Jan 17 2019, 21:24

Complete backport rather than partial

src/wallet/wallet.h
483 ↗(On Diff #6718)

Differs from the original backport because this is needed to support line int age = pcoin.wtx->GetDepthInMainChain(); in CWallet::CreateTransaction() which Core removed in this PR: https://github.com/bitcoin/bitcoin/pull/9602 It would require us to remove free transactions, so I left it out.

This revision is now accepted and ready to land.Jan 18 2019, 11:07