Page MenuHomePhabricator
Differential D2335

Merge #10165: [Wallet] Refactoring by using CInputCoin instead of std::pair
ClosedPublic
Actions

Authored by jasonbcox on Jan 17 2019, 19:17.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING53a858a4808e: Merge #10165: [Wallet] Refactoring by using CInputCoin instead of std::pair
rABC53a858a4808e: Merge #10165: [Wallet] Refactoring by using CInputCoin instead of std::pair
Summary

Backport of Core PR10165
https://github.com/bitcoin/bitcoin/pull/10165/files

Completes T523

Co-authored-by: Jason B. Cox <contact@jasonbcox.com>

Test Plan

ninja check
make check
bitcoin-qt loads and can send transactions as expected

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr10165
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4564
Build 7191: Bitcoin ABC Buildbot (legacy)
Build 7190: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Jan 17 2019, 19:17
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 17 2019, 19:17
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Jan 17 2019, 19:19

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

jasonbcox planned changes to this revision.Jan 17 2019, 19:21
teamcity added a comment.Jan 17 2019, 19:27

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4564: Diff 6717.Jan 17 2019, 19:27
jasonbcox requested review of this revision.Jan 17 2019, 19:50
jasonbcox planned changes to this revision.Jan 17 2019, 21:17
jasonbcox retitled this revision from [Wallet] Rename std::pair<const CWalletTx*, unsigned int> to CInputCoin to Merge #10165: [Wallet] Refactoring by using CInputCoin instead of std::pair.Jan 17 2019, 21:24
jasonbcox updated this revision to Diff 6718.Jan 17 2019, 21:25

Complete backport rather than partial

jasonbcox edited the summary of this revision. (Show Details)Jan 17 2019, 21:25
teamcity added a comment.Jan 17 2019, 21:27

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jan 17 2019, 21:36

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4565: Diff 6718.Jan 17 2019, 21:36
jasonbcox added inline comments.Jan 17 2019, 21:40
src/wallet/wallet.h
483 ↗(On Diff #6718)

Differs from the original backport because this is needed to support line int age = pcoin.wtx->GetDepthInMainChain(); in CWallet::CreateTransaction() which Core removed in this PR: https://github.com/bitcoin/bitcoin/pull/9602 It would require us to remove free transactions, so I left it out.

jasonbcox edited the summary of this revision. (Show Details)Jan 17 2019, 21:41
Fabien accepted this revision.Jan 18 2019, 11:07
This revision is now accepted and ready to land.Jan 18 2019, 11:07
jasonbcox edited the test plan for this revision. (Show Details)Jan 18 2019, 18:40
Closed by commit rABC53a858a4808e: Merge #10165: [Wallet] Refactoring by using CInputCoin instead of std::pair (authored by NicolasDorier <nicolas.dorier@gmail.com>, committed by jasonbcox). · Explain WhyJan 18 2019, 19:01
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
bench/
2 lines
wallet/
test/
2 lines
20 lines
47 lines

Diff 6717

View Options

src/bench/coin_selection.cpp

Loading...
View Options

src/wallet/test/wallet_tests.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...