Page MenuHomePhabricator

add Schnorr support to VerifySignature via flag SCRIPT_ENABLE_SCHNORR
AbandonedPublic

Authored by markblundeberg on Jan 22 2019, 00:34.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Maniphest Tasks
T527: Add Schnorr support to OP_CHECKSIG and OP_CHECKDATASIG
Summary

Schnorr signatures can now be passed to VerifySignature.

A function IsSchnorrSignature was also added to sigencoding.h, since in a
future revision this will also be called from CheckRawSignatureEncoding.

Depends on D2373 and D2348

(replaces D2355)

Test Plan

new test module (sigcache_tests.cpp) added, to make sure that
Schnorr/ECDSA cache collisions are not occurring. When I tried adding
SCRIPT_ENABLE_SCHNORR into the cache's INVARIANT_FLAGS, then this test fails
as expected.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
add-schnorr-sigverifycache
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 4626
Build 7315: Bitcoin ABC Buildbot (legacy)
Build 7314: arc lint + arc unit

Event Timeline

markblundeberg created this revision.Jan 22 2019, 00:34
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 22 2019, 00:34
Herald added a subscriber: schancel. · View Herald Transcript
markblundeberg planned changes to this revision.Jan 22 2019, 06:14

Hmm IsSchnorrSignature is not done correctly here to be reused in CheckRawSignatureEncoding.

markblundeberg abandoned this revision.Jan 29 2019, 01:06

being replaced ...