Differential D2345

API rename: Sign->SignECDSA, Verify->VerifyECDSA
ClosedPublic
Actions

Authored by markblundeberg on Jan 19 2019, 17:13.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Maniphest Tasks

T527: Add Schnorr support to OP_CHECKSIG and OP_CHECKDATASIG

Commits

rSTAGINGec83c14d4a84: API rename: Sign->SignECDSA, Verify->VerifyECDSA
rABCec83c14d4a84: API rename: Sign->SignECDSA, Verify->VerifyECDSA

Summary

This is being done simply for additional clarity when Schnorr sigs are
introduced in future.

Test Plan

Trivial renames -- it compiles = success.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

markblundeberg created this revision.Jan 19 2019, 17:13

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 19 2019, 17:13

Herald added a reviewer: deadalnix. · View Herald Transcript

Herald added a subscriber: schancel. · View Herald Transcript

Only one doubt: are there any external programs that call into this API?

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B4583: Diff 6748.Jan 19 2019, 17:38

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

markblundeberg mentioned this in D2347: API renames of script signature functions to mention ECDSA.Jan 19 2019, 19:37

markblundeberg added a child revision: D2348: Add CKey::SignSchnorr and CPubKey::VerifySchnorr.Jan 19 2019, 20:10

markblundeberg mentioned this in D2342: WIP: add Schnorr opcode support.Jan 19 2019, 21:31

deadalnix accepted this revision.Jan 20 2019, 00:26

This revision is now accepted and ready to land.Jan 20 2019, 00:26

Closed by commit rABCec83c14d4a84: API rename: Sign->SignECDSA, Verify->VerifyECDSA (authored by Mark Lundeberg). · Explain WhyJan 20 2019, 03:20

This revision was automatically updated to reflect the committed changes.

markblundeberg added a task: T527: Add Schnorr support to OP_CHECKSIG and OP_CHECKDATASIG.Jan 20 2019, 07:31

Revision Contents
Changeset List

			Path	Packages
M			src/key.h (13 lines)
M			src/key.cpp (8 lines)
M			src/pubkey.h (11 lines)
M			src/pubkey.cpp (4 lines)
M			src/script/interpreter.cpp (2 lines)
M			src/script/sign.cpp (2 lines)
M			src/test/checkdatasig_tests.cpp (2 lines)
M			src/test/key_tests.cpp (56 lines)
M			src/test/multisig_tests.cpp (2 lines)
M			src/test/script_tests.cpp (10 lines)
M			src/test/txvalidationcache_tests.cpp (10 lines)

Diff 6757

src/key.h

Loading...

src/key.cpp

Loading...

src/pubkey.h

Loading...

src/pubkey.cpp

Loading...

src/script/interpreter.cpp

Loading...

src/script/sign.cpp

Loading...

src/test/checkdatasig_tests.cpp

Loading...

src/test/key_tests.cpp

Loading...

src/test/multisig_tests.cpp

Loading...

src/test/script_tests.cpp

Loading...

src/test/txvalidationcache_tests.cpp

Loading...