Page MenuHomePhabricator
Differential D2345

API rename: Sign->SignECDSA, Verify->VerifyECDSA
ClosedPublic
Actions

Authored by markblundeberg on Jan 19 2019, 17:13.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Maniphest Tasks
T527: Add Schnorr support to OP_CHECKSIG and OP_CHECKDATASIG
Commits
rSTAGINGec83c14d4a84: API rename: Sign->SignECDSA, Verify->VerifyECDSA
rABCec83c14d4a84: API rename: Sign->SignECDSA, Verify->VerifyECDSA
Summary

This is being done simply for additional clarity when Schnorr sigs are
introduced in future.

Test Plan

Trivial renames -- it compiles = success.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
rename-ecdsa
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4583
Build 7229: Bitcoin ABC Buildbot (legacy)
Build 7228: arc lint + arc unit

Event Timeline

markblundeberg created this revision.Jan 19 2019, 17:13
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 19 2019, 17:13
Herald added a reviewer: deadalnix. · View Herald Transcript
Herald added a subscriber: schancel. · View Herald Transcript
markblundeberg added a comment.Jan 19 2019, 17:16

Only one doubt: are there any external programs that call into this API?

teamcity added a subscriber: teamcity.Jan 19 2019, 17:16

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B4583: Diff 6748.Jan 19 2019, 17:38
teamcity added a comment.Jan 19 2019, 17:38

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

markblundeberg mentioned this in D2347: API renames of script signature functions to mention ECDSA.Jan 19 2019, 19:37
markblundeberg added a child revision: D2348: Add CKey::SignSchnorr and CPubKey::VerifySchnorr.Jan 19 2019, 20:10
markblundeberg mentioned this in D2342: WIP: add Schnorr opcode support.Jan 19 2019, 21:31
deadalnix accepted this revision.Jan 20 2019, 00:26
This revision is now accepted and ready to land.Jan 20 2019, 00:26
Closed by commit rABCec83c14d4a84: API rename: Sign->SignECDSA, Verify->VerifyECDSA (authored by Mark Lundeberg). · Explain WhyJan 20 2019, 03:20
This revision was automatically updated to reflect the committed changes.
markblundeberg added a task: T527: Add Schnorr support to OP_CHECKSIG and OP_CHECKDATASIG.Jan 20 2019, 07:31

Revision Contents
Changeset List

PathSize
src/
13 lines
8 lines
11 lines
4 lines
script/
2 lines
2 lines
test/
2 lines
56 lines
2 lines
10 lines
10 lines

Diff 6748

View Options

src/key.h

Loading...
View Options

src/key.cpp

Loading...
View Options

src/pubkey.h

Loading...
View Options

src/pubkey.cpp

Loading...
View Options

src/script/interpreter.cpp

Loading...
View Options

src/script/sign.cpp

Loading...
View Options

src/test/checkdatasig_tests.cpp

Loading...
View Options

src/test/key_tests.cpp

Loading...
View Options

src/test/multisig_tests.cpp

Loading...
View Options

src/test/script_tests.cpp

Loading...
View Options

src/test/txvalidationcache_tests.cpp

Loading...