Page MenuHomePhabricator
Differential D2392

Fix uninitialized g_connman crash in Shutdown()
ClosedPublic
Actions

Authored by Fabien on Jan 23 2019, 13:05.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGefe381b638ba: Fix uninitialized g_connman crash in Shutdown()
rABCefe381b638ba: Fix uninitialized g_connman crash in Shutdown()
Summary

Under some circumstances if an error occurs at init, a segfault is
raised at shutdown.

Backport of core PR11326

Test Plan
./src/bitcoind -wallet=/tmp/wallet.dat (the file should not exist)

Check that an error is shown and:

  • before the patch, the app gets a segfault
  • after the patch, the app shuts down properly

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR11326
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4661
Build 7385: Bitcoin ABC Buildbot (legacy)
Build 7384: arc lint + arc unit

Event Timeline

Fabien created this revision.Jan 23 2019, 13:05
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 23 2019, 13:05
Herald added a reviewer: deadalnix. · View Herald Transcript
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Jan 23 2019, 13:07

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fabien added a child revision: D2393: Fix shutdown in case of errors during initialization.Jan 23 2019, 13:18
teamcity added a comment.Jan 23 2019, 13:20

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4661: Diff 6865.Jan 23 2019, 13:21
deadalnix added a comment.Jan 23 2019, 14:43

You should group these backports with the original patch you backport as to not leave master vulnerable.

deadalnix accepted this revision.Jan 23 2019, 14:43
This revision is now accepted and ready to land.Jan 23 2019, 14:43
Closed by commit rABCefe381b638ba: Fix uninitialized g_connman crash in Shutdown() (authored by MeshCollider <dobsonsa68@gmail.com>, committed by Fabien). · Explain WhyJan 23 2019, 16:53
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rSTAGINGefe381b638ba: Fix uninitialized g_connman crash in Shutdown().Sep 18 2019, 22:03

Revision Contents
Changeset List

PathSize
src/
4 lines

Diff 6865

View Options

src/init.cpp

Loading...