Page MenuHomePhabricator
Differential D2396

Improve TestNodeCLI output parsing
ClosedPublic
Actions

Authored by Fabien on Jan 23 2019, 17:28.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING56b34d8e6470: Improve TestNodeCLI output parsing
rABC56b34d8e6470: Improve TestNodeCLI output parsing
Summary

Parse JSONRPCException errors, and avoid JSON decode exception if RPC
method returns a plain string.

Partial backport of core PR11970 (commit fcfb952)

Depends on D2395

Test Plan
./test/functional/test_runner.py interface_bitcoin_cli

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR11970_part1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4667
Build 7397: Bitcoin ABC Buildbot (legacy)
Build 7396: arc lint + arc unit

Event Timeline

Fabien created this revision.Jan 23 2019, 17:28
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 23 2019, 17:28
Herald added a reviewer: deadalnix. · View Herald Transcript
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Jan 23 2019, 17:28

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fabien added a child revision: D2397: Prevent TestNodeCLI.args mixups.Jan 23 2019, 17:30
teamcity added a comment.Jan 23 2019, 17:41

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4667: Diff 6875.Jan 23 2019, 17:41
Fabien updated this revision to Diff 6894.Jan 24 2019, 09:36

Rebase

teamcity added a comment.Jan 24 2019, 09:38

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jan 24 2019, 09:53

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4680: Diff 6894.Jan 24 2019, 09:53
deadalnix accepted this revision.Jan 24 2019, 14:36
This revision is now accepted and ready to land.Jan 24 2019, 14:36
Closed by commit rABC56b34d8e6470: Improve TestNodeCLI output parsing (authored by Russell Yanofsky <russ@yanofsky.org>, committed by Fabien). · Explain WhyJan 24 2019, 17:09
This revision was automatically updated to reflect the committed changes.
Fabien mentioned this in T211: Backport Core PR11970: Add test coverage for bitcoin-cli multiwallet calls.May 27 2019, 11:54
Fabien added a commit: rSTAGING56b34d8e6470: Improve TestNodeCLI output parsing.Sep 18 2019, 22:04

Revision Contents
Changeset List

PathSize
test/
functional/
test_framework/
14 lines

Diff 6875

View Options

test/functional/test_framework/test_node.py

Loading...