Page MenuHomePhabricator
Differential D2401

Merge #10295: [qt] Move some WalletModel functions into CWallet
ClosedPublic
Actions

Authored by jasonbcox on Jan 23 2019, 19:19.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING8e43c6385504: Merge #10295: [qt] Move some WalletModel functions into CWallet
rABC8e43c6385504: Merge #10295: [qt] Move some WalletModel functions into CWallet
Summary

108f04f Add missing LOCK2 in CWallet::GetAvailableBalance (Russell Yanofsky)
429aa9e [test] Move some tests from qt -> wallet (Russell Yanofsky)
d944bd7 [qt] Move some WalletModel functions into CWallet (Russell Yanofsky)
ef8ca17 [test] Add tests for some walletmodel functions (Russell Yanofsky)

Tree-SHA512: f6384d9f2ff3f7fb173d414588c3e7dc8c311b8ed2ce2b0979fb824a0ed83a7302890ccd3d83197f07f6fdcb6b1ca151584d90ea1961d88dfe8956c87087cde8

Backport of Core PR10295
Completes T516

Test Plan

make check
bitcoin-qt balances display as expected, before and after sending a tx

Diff Detail

Repository
rABC Bitcoin ABC
Branch
arcpatch-D2401
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4703
Build 7469: Bitcoin ABC Buildbot (legacy)
Build 7468: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Jan 23 2019, 19:19
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 23 2019, 19:19
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Jan 23 2019, 19:21

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

jasonbcox edited the test plan for this revision. (Show Details)Jan 23 2019, 19:21
teamcity added a comment.Jan 23 2019, 19:34

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4673: Diff 6881.Jan 23 2019, 19:34
jasonbcox edited the test plan for this revision. (Show Details)Jan 23 2019, 19:52
deadalnix requested changes to this revision.Jan 24 2019, 14:11
deadalnix added inline comments.
src/qt/walletmodel.cpp
611 ↗(On Diff #6881)

Move comment on its own line

This revision now requires changes to proceed.Jan 24 2019, 14:11
jasonbcox updated this revision to Diff 6930.Jan 24 2019, 20:32

Rebase + fixed comment

teamcity added a comment.Jan 24 2019, 20:34

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jan 24 2019, 20:47

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4703: Diff 6930.Jan 24 2019, 20:47
Fabien accepted this revision.Jan 25 2019, 10:46
deadalnix accepted this revision.Jan 25 2019, 21:44
This revision is now accepted and ready to land.Jan 25 2019, 21:44
Closed by commit rABC8e43c6385504: Merge #10295: [qt] Move some WalletModel functions into CWallet (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by jasonbcox). · Explain WhyJan 25 2019, 22:33
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rSTAGING8e43c6385504: Merge #10295: [qt] Move some WalletModel functions into CWallet.Sep 18 2019, 22:06

Revision Contents
Changeset List

PathSize
src/
3 lines
qt/
test/
1 line
9 lines
89 lines
wallet/
test/
105 lines
20 lines
108 lines

Diff 6930

View Options

src/Makefile.qttest.include

Loading...
View Options

src/qt/test/CMakeLists.txt

Loading...
View Options

src/qt/test/wallettests.cpp

Loading...
View Options

src/qt/walletmodel.cpp

Loading...
View Options

src/wallet/test/wallet_tests.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...