Page MenuHomePhabricator

Merge #10295: [qt] Move some WalletModel functions into CWallet
ClosedPublic

Authored by jasonbcox on Jan 23 2019, 19:19.

Details

Summary

108f04f Add missing LOCK2 in CWallet::GetAvailableBalance (Russell Yanofsky)
429aa9e [test] Move some tests from qt -> wallet (Russell Yanofsky)
d944bd7 [qt] Move some WalletModel functions into CWallet (Russell Yanofsky)
ef8ca17 [test] Add tests for some walletmodel functions (Russell Yanofsky)

Tree-SHA512: f6384d9f2ff3f7fb173d414588c3e7dc8c311b8ed2ce2b0979fb824a0ed83a7302890ccd3d83197f07f6fdcb6b1ca151584d90ea1961d88dfe8956c87087cde8

Backport of Core PR10295
Completes T516

Test Plan

make check
bitcoin-qt balances display as expected, before and after sending a tx

Diff Detail

Repository
rABC Bitcoin ABC
Branch
arcpatch-D2401
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4703
Build 7469: Bitcoin ABC Buildbot (legacy)
Build 7468: arc lint + arc unit

Event Timeline

deadalnix requested changes to this revision.Jan 24 2019, 14:11
deadalnix added inline comments.
src/qt/walletmodel.cpp
611 ↗(On Diff #6881)

Move comment on its own line

This revision now requires changes to proceed.Jan 24 2019, 14:11
This revision is now accepted and ready to land.Jan 25 2019, 21:44