Page MenuHomePhabricator
Differential D2415

Split up key and script metadata for better type safety
ClosedPublic
Actions

Authored by Fabien on Jan 25 2019, 15:43.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING2f428eba8c08: Split up key and script metadata for better type safety
rABC2f428eba8c08: Split up key and script metadata for better type safety
Summary

Refactoring only, no functional change

Backport of core PR11854

Test Plan
make check
./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Jan 25 2019, 15:43
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 25 2019, 15:43
Herald added a reviewer: deadalnix. · View Herald Transcript
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Jan 25 2019, 15:45

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fabien retitled this revision from Split up key and script metadata for better type safety Refactoring only, no functional change to Split up key and script metadata for better type safety.Jan 25 2019, 15:48
Fabien edited the summary of this revision. (Show Details)
teamcity added a comment.Jan 25 2019, 16:00

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4706: Diff 6936.Jan 25 2019, 16:00
Fabien added a child revision: D2416: Add scripts to dumpwallet RPC.Jan 25 2019, 16:51
jasonbcox accepted this revision.Jan 25 2019, 22:44
This revision is now accepted and ready to land.Jan 25 2019, 22:44
Closed by commit rABC2f428eba8c08: Split up key and script metadata for better type safety (authored by Russell Yanofsky <russ@yanofsky.org>, committed by Fabien). · Explain WhyJan 28 2019, 07:24
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rSTAGING2f428eba8c08: Split up key and script metadata for better type safety.Sep 18 2019, 22:07

Revision Contents
Changeset List

PathSize
src/
rpc/
29 lines
wallet/
13 lines
16 lines
24 lines

Diff 6955

View Options

src/rpc/misc.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...
View Options

src/wallet/walletdb.cpp

Loading...