Don't use pass by reference to const for cheaply-copied types (bool, char, etc.).
ClosedPublic
Actions

Authored by jasonbcox on Jan 28 2019, 20:09.

Details

Reviewers

deadalnix
Fabien

Group Reviewers

Restricted Project

Commits

rSTAGINGde86c70c2d6b: Don't use pass by reference to const for cheaply-copied types (bool, char, etc.
rABCde86c70c2d6b: Don't use pass by reference to const for cheaply-copied types (bool, char, etc.

Summary

Backport Core PR10839
https://github.com/bitcoin/bitcoin/pull/10839/files
Completes T508

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr10839

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4725
Build 7513: Bitcoin ABC Buildbot (legacy)
Build 7512: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Jan 28 2019, 20:09

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 28 2019, 20:09

Herald added a subscriber: schancel. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fabien accepted this revision.Jan 28 2019, 20:21

This revision is now accepted and ready to land.Jan 28 2019, 20:21

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4725: Diff 6970.Jan 28 2019, 20:25

Closed by commit rABCde86c70c2d6b: Don't use pass by reference to const for cheaply-copied types (bool, char, etc. (authored by practicalswift <practicalswift@users.noreply.github.com>, committed by jasonbcox). · Explain WhyJan 28 2019, 22:19

This revision was automatically updated to reflect the committed changes.

jasonbcox added a commit: rSTAGINGde86c70c2d6b: Don't use pass by reference to const for cheaply-copied types (bool, char, etc..Sep 18 2019, 22:08

Revision Contents
Changeset List

Path

Size

src/

qt/

sendcoinsdialog.cpp

2 lines

streams.h

4 lines

wallet/

rpcdump.cpp

4 lines

wallet.h

10 lines

wallet.cpp

8 lines

Diff 6970

View Options

src/qt/sendcoinsdialog.cpp

View Options

src/streams.h

View Options

src/wallet/rpcdump.cpp

View Options

src/wallet/wallet.h

View Options

Don't use pass by reference to const for cheaply-copied types (bool, char, etc.).ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 6970

src/qt/sendcoinsdialog.cpp

src/streams.h

src/wallet/rpcdump.cpp

src/wallet/wallet.h

src/wallet/wallet.cpp

Don't use pass by reference to const for cheaply-copied types (bool, char, etc.).
ClosedPublic
Actions

Revision Contents
Changeset List