Page MenuHomePhabricator

Remove NODE_WITNESS from messages.py
ClosedPublic

Authored by Fabien on Jan 30 2019, 11:11.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC0ecab1630825: Remove NODE_WITNESS from messages.py
Summary

This is not used in any test.

Test Plan
./test/functional/test_runner.py --extended

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Jan 30 2019, 11:11
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 30 2019, 11:11
Herald added a subscriber: schancel. · View Herald Transcript
deadalnix requested changes to this revision.Jan 30 2019, 13:32

Please keep it around, it's still more or less part of the protocol at this point in time.

This revision now requires changes to proceed.Jan 30 2019, 13:32
Fabien requested review of this revision.Jan 30 2019, 13:38

What do you think keeping it commented out (just like NODE_GETUTXO) ?

deadalnix requested changes to this revision.Jan 30 2019, 22:45
This revision now requires changes to proceed.Jan 30 2019, 22:45
Fabien updated this revision to Diff 7048.Jan 31 2019, 10:28

Comment instead of removing

deadalnix accepted this revision.Jan 31 2019, 14:51
This revision is now accepted and ready to land.Jan 31 2019, 14:51
This revision was automatically updated to reflect the committed changes.