Page MenuHomePhabricator

Remove NODE_WITNESS from messages.py
ClosedPublic

Authored by Fabien on Jan 30 2019, 11:11.

Details

Summary

This is not used in any test.

Test Plan
./test/functional/test_runner.py --extended

Diff Detail

Repository
rABC Bitcoin ABC
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4764
Build 7591: Bitcoin ABC Buildbot (legacy)
Build 7590: arc lint + arc unit

Event Timeline

deadalnix requested changes to this revision.Jan 30 2019, 13:32

Please keep it around, it's still more or less part of the protocol at this point in time.

This revision now requires changes to proceed.Jan 30 2019, 13:32
Fabien requested review of this revision.Jan 30 2019, 13:38

What do you think keeping it commented out (just like NODE_GETUTXO) ?

deadalnix requested changes to this revision.Jan 30 2019, 22:45
This revision now requires changes to proceed.Jan 30 2019, 22:45

Comment instead of removing

This revision is now accepted and ready to land.Jan 31 2019, 14:51
This revision was automatically updated to reflect the committed changes.