Page MenuHomePhabricator
Differential D2443

Remove NODE_WITNESS from messages.py
ClosedPublic
Actions

Authored by Fabien on Jan 30 2019, 11:11.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING0ecab1630825: Remove NODE_WITNESS from messages.py
rABC0ecab1630825: Remove NODE_WITNESS from messages.py
Summary

This is not used in any test.

Test Plan
./test/functional/test_runner.py --extended

Diff Detail

Repository
rABC Bitcoin ABC
Branch
witness_remove_py
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4782
Build 7627: Bitcoin ABC Buildbot (legacy)
Build 7626: arc lint + arc unit

Event Timeline

Fabien created this revision.Jan 30 2019, 11:11
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 30 2019, 11:11
Herald added a reviewer: deadalnix. · View Herald Transcript
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Jan 30 2019, 11:11

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B4764: Diff 7017.Jan 30 2019, 11:25
teamcity added a comment.Jan 30 2019, 11:25

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

deadalnix requested changes to this revision.Jan 30 2019, 13:32

Please keep it around, it's still more or less part of the protocol at this point in time.

This revision now requires changes to proceed.Jan 30 2019, 13:32
Fabien requested review of this revision.Jan 30 2019, 13:38

What do you think keeping it commented out (just like NODE_GETUTXO) ?

deadalnix added a comment.Jan 30 2019, 20:21

ok.

deadalnix requested changes to this revision.Jan 30 2019, 22:45
This revision now requires changes to proceed.Jan 30 2019, 22:45
Fabien updated this revision to Diff 7048.Jan 31 2019, 10:28

Comment instead of removing

teamcity added a comment.Jan 31 2019, 10:29

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jan 31 2019, 10:45

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4782: Diff 7048.Jan 31 2019, 10:45
deadalnix accepted this revision.Jan 31 2019, 14:51
This revision is now accepted and ready to land.Jan 31 2019, 14:51
Closed by commit rABC0ecab1630825: Remove NODE_WITNESS from messages.py (authored by Fabien). · Explain WhyJan 31 2019, 16:43
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rSTAGING0ecab1630825: Remove NODE_WITNESS from messages.py.Sep 18 2019, 22:11

Revision Contents
Changeset List

PathSize
test/
functional/
test_framework/
2 lines

Diff 7048

View Options

test/functional/test_framework/messages.py

Loading...