Page MenuHomePhabricator

Check for unused imports in *.py files
ClosedPublic

Authored by Fabien on Wed, Jan 30, 14:58.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Commits
rABCdf298ba489b3: Check for unused imports in *.py files
Summary

Using flake8 code F401, unused imports are output as lint errors from
acanist.
flake8 is preferred here over pylint because it offers more feature for
the long-term improvement. It could also throw pep8 errors but will not
fix them like autopep8 does, so better use both.

Based on core PR11835

Depends on D2445, D2446, D2447, D2448, D2449, D2450

Test Plan

Add an unused import in a py file and run arc lint. An error should be
reported
Read the CONTRIBUTING.md doc

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Wed, Jan 30, 14:58
Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Jan 30, 14:58
Herald added a subscriber: schancel. · View Herald Transcript
jasonbcox accepted this revision.Wed, Jan 30, 16:54
This revision is now accepted and ready to land.Wed, Jan 30, 16:54
This revision was automatically updated to reflect the committed changes.