Use compile-time constants instead of unnamed enumerations
ClosedPublic
Actions

Authored by Fabien on Jan 30 2019, 16:07.

Details

Reviewers

deadalnix
jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGINGaadde70bfcb4: Use compile-time constants instead of unnamed enumerations
rABCaadde70bfcb4: Use compile-time constants instead of unnamed enumerations

Summary

Remove "enum hack"

Backport of core PR10749

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR10749

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4775
Build 7613: Bitcoin ABC Buildbot (legacy)
Build 7612: arc lint + arc unit

Event Timeline

Fabien created this revision.Jan 30 2019, 16:07

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 30 2019, 16:07

Herald added a reviewer: deadalnix. · View Herald Transcript

Herald added a subscriber: schancel. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4775: Diff 7034.Jan 30 2019, 16:22

jasonbcox accepted this revision.Jan 30 2019, 22:41

This revision is now accepted and ready to land.Jan 30 2019, 22:41

Closed by commit rABCaadde70bfcb4: Use compile-time constants instead of unnamed enumerations (authored by practicalswift <practicalswift@users.noreply.github.com>, committed by Fabien). · Explain WhyJan 31 2019, 11:04

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rSTAGINGaadde70bfcb4: Use compile-time constants instead of unnamed enumerations.Sep 18 2019, 22:10

Revision Contents
Changeset List

Path

Size

src/

arith_uint256.h

2 lines

chain.h

2 lines

consensus/

consensus.h

11 lines

protocol.h

21 lines

uint256.h

2 lines

Diff 7034

View Options

src/arith_uint256.h

View Options

src/chain.h

View Options

src/consensus/consensus.h

View Options

src/protocol.h

View Options

Use compile-time constants instead of unnamed enumerationsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 7034

src/arith_uint256.h

src/chain.h

src/consensus/consensus.h

src/protocol.h

src/uint256.h

Use compile-time constants instead of unnamed enumerations
ClosedPublic
Actions

Revision Contents
Changeset List