[avalanche] Make sure we keep the read lock when reading from VoteRecord
ClosedPublic
Actions

Authored by deadalnix on Feb 1 2019, 02:21.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING7c8ac2540b73: [avalanche] Make sure we keep the read lock when reading from VoteRecord
rABC7c8ac2540b73: [avalanche] Make sure we keep the read lock when reading from VoteRecord

Summary

At least two function read from VoteRecord after releasing the read lock from vote_records, which is incorrect.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

avalock

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4804
Build 7671: Bitcoin ABC Buildbot (legacy)
Build 7670: arc lint + arc unit

Event Timeline

deadalnix created this revision.Feb 1 2019, 02:21

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 1 2019, 02:21

Herald added a subscriber: schancel. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4804: Diff 7081.Feb 1 2019, 02:37

deadalnix added a child revision: D2486: [avalanche] Limit the number of in flight request per item..Feb 3 2019, 16:43

jasonbcox accepted this revision.Feb 3 2019, 17:02

This revision is now accepted and ready to land.Feb 3 2019, 17:02

Closed by commit rABC7c8ac2540b73: [avalanche] Make sure we keep the read lock when reading from VoteRecord (authored by deadalnix). · Explain WhyFeb 3 2019, 17:04

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rSTAGING7c8ac2540b73: [avalanche] Make sure we keep the read lock when reading from VoteRecord.Sep 18 2019, 22:13

Revision Contents
Changeset List

Path

Size

src/

avalanche.cpp

24 lines

Diff 7081

View Options

[avalanche] Make sure we keep the read lock when reading from VoteRecordClosedPublicActions