Page MenuHomePhabricator

[avalanche] Limit the number of in flight request per item.
ClosedPublic

Authored by deadalnix on Feb 3 2019, 16:43.

Details

Summary

It is paramount that avalanche is able to pace itself based on the speed at which the peer can respond.

Depends on D2474, D2473, D2472, D2470, D2484, D2485 and D2471

Test Plan

Added test cases.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Feb 3 2019, 16:43
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 3 2019, 16:43
Herald added a subscriber: schancel. · View Herald Transcript
jasonbcox accepted this revision.Feb 3 2019, 20:05
jasonbcox added a subscriber: jasonbcox.

Some nits. All else LGTM.

src/avalanche.cpp
45 ↗(On Diff #7132)

clearInflighRequest -> clearInflightRequest

390 ↗(On Diff #7132)

could use auto here instead of writing out std::pair<...>

src/test/avalanche_tests.cpp
119 ↗(On Diff #7132)

everythign -> everything

This revision is now accepted and ready to land.Feb 3 2019, 20:05
This revision was automatically updated to reflect the committed changes.