Page MenuHomePhabricator
Differential D2486

[avalanche] Limit the number of in flight request per item.
ClosedPublic
Actions

Authored by deadalnix on Feb 3 2019, 16:43.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING2c67253db8eb: [avalanche] Limit the number of in flight request per item.
rABC2c67253db8eb: [avalanche] Limit the number of in flight request per item.
Summary

It is paramount that avalanche is able to pace itself based on the speed at which the peer can respond.

Depends on D2474, D2473, D2472, D2470, D2484, D2485 and D2471

Test Plan

Added test cases.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
avainflight
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4848
Build 7759: Bitcoin ABC Buildbot (legacy)
Build 7758: arc lint + arc unit

Event Timeline

deadalnix created this revision.Feb 3 2019, 16:43
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 3 2019, 16:43
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Feb 3 2019, 16:47

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Feb 3 2019, 17:02

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4847: Diff 7132.Feb 3 2019, 17:02
deadalnix updated this revision to Diff 7140.Feb 3 2019, 17:24

rebase

teamcity added a comment.Feb 3 2019, 17:25

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Feb 3 2019, 17:39

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4848: Diff 7140.Feb 3 2019, 17:39
jasonbcox accepted this revision.Feb 3 2019, 20:05
jasonbcox added a subscriber: jasonbcox.

Some nits. All else LGTM.

src/avalanche.cpp
45 ↗(On Diff #7132)

clearInflighRequest -> clearInflightRequest

390 ↗(On Diff #7132)

could use auto here instead of writing out std::pair<...>

src/test/avalanche_tests.cpp
119 ↗(On Diff #7132)

everythign -> everything

This revision is now accepted and ready to land.Feb 3 2019, 20:05
Closed by commit rABC2c67253db8eb: [avalanche] Limit the number of in flight request per item. (authored by deadalnix). · Explain WhyFeb 5 2019, 14:36
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rSTAGING2c67253db8eb: [avalanche] Limit the number of in flight request per item..Sep 18 2019, 22:17

Revision Contents
Changeset List

PathSize
src/
38 lines
84 lines
test/
79 lines

Diff 7140

View Options

src/avalanche.h

Loading...
View Options

src/avalanche.cpp

Loading...
View Options

src/test/avalanche_tests.cpp

Loading...