[avalanche] refactor getInvsForNextPoll to limit the scope of cs_main
ClosedPublic
Actions

Authored by deadalnix on Feb 1 2019, 02:35.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING8e40ded09786: [avalanche] refactor getInvsForNextPoll to limit the scope of cs_main
rABC8e40ded09786: [avalanche] refactor getInvsForNextPoll to limit the scope of cs_main

Summary

It's a good idea to limit the scope over which you hold cs_main.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

avainvfornextpolrefac

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4806
Build 7675: Bitcoin ABC Buildbot (legacy)
Build 7674: arc lint + arc unit

Event Timeline

deadalnix created this revision.Feb 1 2019, 02:35

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 1 2019, 02:35

Herald added a subscriber: schancel. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4806: Diff 7083.Feb 1 2019, 02:49

deadalnix added a child revision: D2486: [avalanche] Limit the number of in flight request per item..Feb 3 2019, 16:43

jasonbcox accepted this revision.Feb 3 2019, 17:04

This revision is now accepted and ready to land.Feb 3 2019, 17:04

Closed by commit rABC8e40ded09786: [avalanche] refactor getInvsForNextPoll to limit the scope of cs_main (authored by deadalnix). · Explain WhyFeb 3 2019, 17:22

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rSTAGING8e40ded09786: [avalanche] refactor getInvsForNextPoll to limit the scope of cs_main.Sep 18 2019, 22:14

Revision Contents
Changeset List

Path

Size

src/

avalanche.cpp

16 lines

Diff 7083

View Options

[avalanche] refactor getInvsForNextPoll to limit the scope of cs_mainClosedPublicActions