[avalanche] Refactor the clearing of timed out requests in its own function
ClosedPublic
Actions

Authored by deadalnix on Feb 1 2019, 02:51.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING9f1d5fbe51cf: [avalanche] Refactor the clearing of timed out requests in its own function
rABC9f1d5fbe51cf: [avalanche] Refactor the clearing of timed out requests in its own function

Summary

This makes the purpose of various pieces of code clearer. Because of the locks, it needs to scoped anyways.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

avacleartimeout

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4807
Build 7677: Bitcoin ABC Buildbot (legacy)
Build 7676: arc lint + arc unit

Event Timeline

deadalnix created this revision.Feb 1 2019, 02:51

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 1 2019, 02:51

Herald added a subscriber: schancel. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4807: Diff 7084.Feb 1 2019, 03:06

deadalnix added a child revision: D2486: [avalanche] Limit the number of in flight request per item..Feb 3 2019, 16:43

jasonbcox accepted this revision.Feb 3 2019, 17:00

This revision is now accepted and ready to land.Feb 3 2019, 17:00

Closed by commit rABC9f1d5fbe51cf: [avalanche] Refactor the clearing of timed out requests in its own function (authored by deadalnix). · Explain WhyFeb 3 2019, 17:06

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rSTAGING9f1d5fbe51cf: [avalanche] Refactor the clearing of timed out requests in its own function.Sep 18 2019, 22:14

Revision Contents
Changeset List

Path

Size

src/

avalanche.h

1 line

avalanche.cpp

20 lines

Diff 7084

View Options

src/avalanche.h